Truncate commit message during Discord webhook push events #31970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
kemzeb
commented
Sep 3, 2024
kemzeb
commented
Sep 3, 2024
| return pushTestPayloadWithCommitMessage("This is a commit summary that is longer than 50 characters\n\nThis is the message body.") | ||
| } | ||
|
|
||
| func pushTestPayloadWithCommitMessage(message string) *api.PushPayload { |
There was a problem hiding this comment.
Wanted to avoid test code duplication here by adding these 2 functions. I'm open for alternative ways to writing my test case.
lunny
reviewed
Sep 17, 2024
This is in-line with what our other webhook implementations do.
kemzeb
force-pushed
the
feat-make-discord-msg-more-readable
branch
from
146603a
to
0983b27
Compare
lunny
approved these changes
Sep 18, 2024
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Sep 24, 2024
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 24, 2024
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 25, 2024
* giteaofficial/main: Notify the user when the file path contains leading or trailing spaces and fix the error message for invalid file names. (go-gitea#31507) Fix wrong status of `Set up Job` when first step is skipped (go-gitea#32120) Fix bug when deleting a migrated branch (go-gitea#32075) Include collaboration repositories on dashboard source/forks/mirrors list (go-gitea#31946) Display head branch more comfortable on pull request view (go-gitea#32000) Truncate commit message during Discord webhook push events (go-gitea#31970) Fix template bug of pull request view (go-gitea#32072)
This was referenced Nov 6, 2024
lunny
pushed a commit
that referenced
this pull request
Nov 7, 2024
Resolves #32371. #31970 should have just showed the commit summary, but `strings.SplitN()` was misused such that we did not perform any splitting at all and just used the message. This was not caught in the unit test made in that PR since the test commit summary was > 50 (which truncated away the commit description). This snapshot resolves this and adds another unit test to ensure that we only show the commit summary.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 7, 2024
…itea#32432) Resolves go-gitea#32371. go-gitea#31970 should have just showed the commit summary, but `strings.SplitN()` was misused such that we did not perform any splitting at all and just used the message. This was not caught in the unit test made in that PR since the test commit summary was > 50 (which truncated away the commit description). This snapshot resolves this and adds another unit test to ensure that we only show the commit summary.
lunny
pushed a commit
that referenced
this pull request
Nov 8, 2024
…) (#32447) Backport #32432 by @kemzeb Resolves #32371. #31970 should have just showed the commit summary, but `strings.SplitN()` was misused such that we did not perform any splitting at all and just used the message. This was not caught in the unit test made in that PR since the test commit summary was > 50 (which truncated away the commit description). This snapshot resolves this and adds another unit test to ensure that we only show the commit summary. Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31668.