Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logic of finding the latest pull review commit ID #32139

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Fix the logic of finding the latest pull review commit ID #32139

merged 7 commits into from
Oct 1, 2024

Conversation

Zettat123
Copy link
Contributor

Fix #31423

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 26, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Sep 26, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 1, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2024
@lunny lunny enabled auto-merge (squash) October 1, 2024 01:29
@lunny lunny merged commit f4b8f6f into go-gitea:main Oct 1, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 1, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 1, 2024
@Zettat123 @GiteaBot
Fix the logic of finding the latest pull review commit ID (go-gitea#3…
18e75f2 
…2139)

Fix go-gitea#31423
@GiteaBot GiteaBot mentioned this pull request Oct 1, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 1, 2024
yp05327 pushed a commit that referenced this pull request Oct 1, 2024
@GiteaBot @Zettat123
Fix the logic of finding the latest pull review commit ID (#32139) (#…
9fc3915 
…32165)

Backport #32139 by @Zettat123

Fix #31423

Co-authored-by: Zettat123 <zettat123@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4f27d60 
* giteaofficial/main:
  Fix javascript error when an anonymous user visiting migration page (go-gitea#32144)
  Make oauth2 code clear. Move oauth2 provider code to their own packages/files (go-gitea#32148)
  Support repo license (go-gitea#24872)
  Fix the logic of finding the latest pull review commit ID (go-gitea#32139)
  Ensure `GetCSRF` doesn't return an empty token (go-gitea#32130)
  Bump minio-go to latest version (go-gitea#32156)
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyguodong sillyguodong sillyguodong left review comments

@yp05327 yp05327 yp05327 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

"Show changes since your last review" button should still show even if a review was requested from me again
5 participants
@Zettat123 @lunny @yp05327 @sillyguodong @GiteaBot