Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the maintainblity of the reserved username list #32229

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Improve the maintainblity of the reserved username list #32229

merged 2 commits into from
Oct 10, 2024

Conversation

wxiaoguang
Copy link
Contributor

The reserved username list was not well maintained before:

  1. Some entries are missing (eg: sitemap.xml)
  2. Some entries do not make sense (eg: new, debug, error, raw)
  3. No idea about what each entry means
  4. It doesn't make sense to copy the list and test it again, and the newly added "reservedUserPatterns" was never tested

After this PR:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 10, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 10, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 10, 2024
@lunny lunny enabled auto-merge (squash) October 10, 2024 05:54
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2024
@lunny lunny merged commit 6029d78 into go-gitea:main Oct 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 10, 2024
@wxiaoguang wxiaoguang deleted the fix-names branch October 10, 2024 09:04
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Oct 10, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
58fd331 
* giteaofficial/main:
  Fix checkbox bug on private/archive filter (go-gitea#32236)
  Improve the maintainblity of the reserved username list (go-gitea#32229)
  Move admin routers from /admin to /-/admin (go-gitea#32189)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @lafriks @GiteaBot