Add reviewers selection to new pull request fixes #26289 #32403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this needs to be a negative integer
logics for fetching reviewers in pull requests is now placed in the RetrieveRepoMetas
the review requet notifaction is now sent after the new pull request notification.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/translation
modifies/api
pull-request-size
bot
added
size/L
CalK16
changed the title
|
Thank you all for the work. Actually IMO there are still problems in this PR, for example: incorrect CSS classes like There is also a blocker in repo-legacy.ts, I have proposed a refactoring PR "Refactor repo legacy #32404", after #32404, I could help to resolve the conflicts here and fix the problems. |
|
Does this replace #26596 ? |
lunny
reviewed
Nov 2, 2024
pull-request-size
bot
added
the
size/XL
|
Made some changes, and merge the duplicate code. Now we just use one "reviewer_list.tmpl" to handle the selection. And the new |
wxiaoguang
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
It's almost done from my side and I would vote my approval.
Some changes seem more than expected, indeed they were done for improving the maintainability, some legacy functions are too complex to maintain.
I have manually tested the New PR page and PR view page. If anything wrong happens, please let me know and I will fix them ASAP.
Screenshots:
GiteaBot
added
lgtm/need 1
wxiaoguang
added
the
type/feature
wxiaoguang
force-pushed
the
main
branch
3 times, most recently
from
44f8163 to
823b1c9
Compare
lunny
approved these changes
Nov 9, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 10, 2024
* giteaofficial/main: Refactor sidebar label selector (go-gitea#32460) Fix mermaid diagram height when initially hidden (go-gitea#32457) Add reviewers selection to new pull request (go-gitea#32403) Fix issue sidebar (go-gitea#32455) Refactor language menu and dom utils (go-gitea#32450) Fix broken releases when re-pushing tags (go-gitea#32435) Refactor issue page info (go-gitea#32445) Split issue sidebar into small templates (go-gitea#32444) Only provide the commit summary for Discord webhook push events (go-gitea#32432) Add new event commit status creation and webhook implementation (go-gitea#27151) Support quote selected comments to reply (go-gitea#32431) Move AddCollabrator and CreateRepositoryByExample to service layer (go-gitea#32419) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl
lunny
reviewed
Nov 21, 2024
| @@ -197,7 +210,17 @@ func NewPullRequest(ctx context.Context, repo *repo_model.Repository, issue *iss | |||
| } | |||
| notify_service.IssueChangeAssignee(ctx, issue.Poster, issue, assignee, false, assigneeCommentMap[assigneeID]) | |||
| } | |||
|
|
|||
| permDoer, err := access_model.GetUserRepoPermission(ctx, repo, issue.Poster) | |||
There was a problem hiding this comment.
Looks like these changes are duplicated as line 193 issue_service.ReviewRequestNotify
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI looks just like the assignee selection here because I think the actions from the pull request edit dialog don't make much sense here. The assignee selection on the pr create and edit pages also differ.
Hi, I've not done this before, so bear with me. I tried to make changes on @splitt3r 's pull request but was rejected due to a permission issue. Therefore, I had to fork my own repository and incorporate what was done in that pull request. In addition to @splitt3r and @sebastian-sauer's commits, I've also added a commit to resolve the conflicts. Furthermore, I have included two other commits to address @jpraet 's comments.
Please let me know if there is anything else I need to address. Thank you!