Refactor render system #32492
Merged
Refactor render system #32492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
wxiaoguang
added
the
type/refactoring
github-actions
bot
added
modifies/api
wxiaoguang
force-pushed
the
refactor-render
branch
7 times, most recently
from
6ea7b24
to
deca667
Compare
wxiaoguang
force-pushed
the
refactor-render
branch
from
deca667
to
a1765f7
Compare
lunny
reviewed
Nov 13, 2024
lunny
approved these changes
Nov 14, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
refactor-render
branch
from
2c5b485
to
142f07e
Compare
Zettat123
approved these changes
Nov 14, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 14, 2024
* giteaofficial/main: Refactor render system (go-gitea#32492) Fix nil panic if repo doesn't exist (go-gitea#32501) Bump CI,Flake and Snap to Node 22 (go-gitea#32487) Perf: add extra index to notification table (go-gitea#32395) Fix LFS route mock, realm, middleware names (go-gitea#32488)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 15, 2024
This reverts commit 3f9c3e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were too many patches to the Render system, it's really difficult to make further improvements.
This PR clears the legacy problems and fix TODOs.
RenderContext.TypetoRenderContext.MarkupTypeto clarify its usage.ContentModeto replacemeta["mode"]andIsWiki, to clarify the rendering behaviors.renderByTypeandrenderByFileThe problem of "mode=document": in many cases it is not set, so many non-comment places use comment's hard line break incorrectly