Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing and try to fix MySQL hanging #32515

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve testing and try to fix MySQL hanging #32515

wants to merge 7 commits into from
+197 −242

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 15, 2024 •
edited
Loading

It's strange that TestLinguist hangs a lot with MySQL (and only MySQL). Update: due to MySQL tests have different indexer&queue behaviors.

Now, by some CI fine tunes (run tests), SQLite & MSSQL could complete in about 12~13 minutes (before > 14), MySQL could complete in 18 minutes (before: about 23 or even > 30)

@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Nov 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/migrations labels Nov 15, 2024
@wxiaoguang wxiaoguang force-pushed the fix-testing branch 2 times, most recently from 85d01db to 8fbff1b Compare November 15, 2024 03:34
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2024
@wxiaoguang wxiaoguang force-pushed the fix-testing branch 3 times, most recently from f6fce34 to 211fc18 Compare November 15, 2024 06:07
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Nov 15, 2024 •
edited
Loading

By some CI fine tunes (run tests), SQLite & MSSQL could complete in about 12~13 minutes (before > 14), MySQL could complete in 18 minutes (before: about 23 or even > 30)

@wxiaoguang wxiaoguang mentioned this pull request Nov 15, 2024
Merged
@bohde
Copy link
Contributor

bohde commented Nov 15, 2024 •
edited
Loading

Am I right that the major changes are as follows?

  • Use ChaCha8 for generating random test files instead of a cryptographic generator, saving 2 minutes per integration test suite
  • Adjust MySQL to run on a tmpfs, saving 4 minutes per mysql integration test suite
  • Don't re-enqueue failed jobs when flushing, which makes tests more reliable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/docs modifies/go Pull requests that update Go code modifies/internal modifies/migrations size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @bohde @lunny @GiteaBot