-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor markup render system #32533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 16, 2024
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Nov 16, 2024
wxiaoguang
force-pushed
the
fix-markdown
branch
4 times, most recently
from
November 16, 2024 14:59
fec8cf3
to
4b6f6fd
Compare
wxiaoguang
force-pushed
the
fix-markdown
branch
4 times, most recently
from
November 16, 2024 17:04
e920099
to
14d260d
Compare
wxiaoguang
force-pushed
the
fix-markdown
branch
from
November 16, 2024 17:11
14d260d
to
50ee93c
Compare
lunny
approved these changes
Nov 16, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 16, 2024
pull-request-size
bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Nov 17, 2024
wxiaoguang
force-pushed
the
fix-markdown
branch
from
November 17, 2024 03:38
a2ac8e5
to
fed44af
Compare
wxiaoguang
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Nov 17, 2024
lunny
pushed a commit
that referenced
this pull request
Nov 18, 2024
This is a backport-only fix for 1.22 1.23 has a proper fix #32533
Zettat123
approved these changes
Nov 18, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 18, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 20, 2024
* giteaofficial/main: Remove duplicate empty repo check in delete branch API (go-gitea#32569) Optimize installation-page experience (go-gitea#32558) Remove unnecessary code (go-gitea#32560) Fix a compilation error in the Gitpod environment (go-gitea#32559) Use user.FullName in Oauth2 id_token response (go-gitea#32542) Fix some places which doesn't repsect org full name setting (go-gitea#32243) Refactor push mirror find and add check for updating push mirror (go-gitea#32539) Refactor markup render system (go-gitea#32533) Refactor find forks and fix possible bugs that weak permissions check (go-gitea#32528) Use better name for userinfo structure (go-gitea#32544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unmaintainable sanitizer rules. No need to add special "class" regexp rules anymore, use RenderInternal.SafeAttr instead, more details (and examples) are in the tests