Fix a bug in actions artifact test #32672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug exists in
TestActionsArtifactDownload
.gitea/tests/integration/api_actions_artifact_test.go
Lines 123 to 134 in a1f56f8
We assert that
listResp.Count
is2
, soartifactIdx
could be0
or1
.gitea/tests/integration/api_actions_artifact_test.go
Lines 144 to 147 in a1f56f8
Then we assert that the length of
downloadResp.Value
is1
. IfartifactIdx
is1
at this point, the assertion on Line 147 will throw anindex out of range
error.