Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the styling of icon buttons within file-header-right #32675

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Nov 29, 2024

Optimize partial layout and styling to achieve uniformity and consistency.

Some buttons's structure is <a><span><svg/></span></a>, while others buttons's structure is <a><svg/></a>. Additionally, some buttons have icons that are 14 in size, while others have icons that are 16.
Now, the layout has been unified to structure <a><svg/></a>, and the icon size for all buttons has been standardized to the default size of 16.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Nov 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2024
@kerwin612 kerwin612 requested a review from a team December 2, 2024 00:03
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2024
@wxiaoguang wxiaoguang merged commit 9a494af into go-gitea:main Dec 2, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 2, 2024
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Dec 2, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 3, 2024
* giteaofficial/main:
  Add "View all branches/tags" entry to Branch Selector (go-gitea#32653)
  Remove all "floated" CSS styles (go-gitea#32691)
  Optimize the styling of icon buttons within file-header-right (go-gitea#32675)
  fix: show tag name on branch/tag selector if repo shown from tag ref (go-gitea#32689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants