Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, tweak eslint #32719

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 5, 2024

  • Remove eslint-plugin-sonarjs. I lost faith in it since they moved it to their monorepo and I can't recall the last time when this plugin raised a useful error.
  • Add new rules from no-jquery
  • Tweak typescript config to prevent temp files in root directory in certain situations File is just gitignored now.
  • Tested all relevant dependencies

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@silverwind
Copy link
Member Author

I think I may reconsider the sonar removal. At least they have now published a changelog: https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/CHANGELOG.md

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2024
@silverwind
Copy link
Member Author

Have restored sonarjs plugin for now, will check on upgrading it later. Pull request is ready.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2024
tsconfig.json Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2024
@silverwind
Copy link
Member Author

Reverted the tsconfig change and just gitignore *.tsbuildInfo now. Reason is that I don't think the composite option is worth to have as we are not even using tsc to compile the typescript.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 5, 2024
@silverwind silverwind enabled auto-merge (squash) December 5, 2024 16:06
@silverwind silverwind merged commit 5cada75 into go-gitea:main Dec 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 5, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 5, 2024
@silverwind silverwind deleted the deps-84 branch December 5, 2024 16:16
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Dec 5, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 6, 2024
* giteaofficial/main:
  Bump relative-time-element to v4.4.4 (go-gitea#32730)
  Update dependencies, tweak eslint (go-gitea#32719)
  Issue time estimate, meaningful time tracking (go-gitea#23113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants