Add file tree to file view page #32721
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/templates
pull-request-size
bot
added
size/L
wxiaoguang
reviewed
Dec 5, 2024
wxiaoguang
reviewed
Dec 5, 2024
wxiaoguang
reviewed
Dec 5, 2024
wxiaoguang
reviewed
Dec 5, 2024
wxiaoguang
reviewed
Dec 5, 2024
wxiaoguang
reviewed
Dec 5, 2024
wxiaoguang
reviewed
Dec 5, 2024
pull-request-size
bot
added
size/XL
|
1 Move the three buttons on top of the left tree when expanding and move to the right once folding. 2 The expanding state should be stored to users' configuration or as a session value once changed. |
kerwin612
force-pushed
the
add-file-tree-to-file-view-page
branch
from
7229b60 to
59e46d4
Compare
pull-request-size
bot
added
size/L
kerwin612
force-pushed
the
add-file-tree-to-file-view-page
branch
from
e45940d to
c4e7f0c
Compare
wxiaoguang
reviewed
Mar 4, 2025
wxiaoguang
force-pushed
the
add-file-tree-to-file-view-page
branch
from
32346a0 to
3bc3cd8
Compare
wxiaoguang
reviewed
Mar 7, 2025
wxiaoguang
reviewed
Mar 7, 2025
wxiaoguang
reviewed
Mar 7, 2025
wxiaoguang
reviewed
Mar 7, 2025
wxiaoguang
reviewed
Mar 7, 2025
| resp: | ||
| [{ | ||
| "name": "d1", | ||
| "isFile": false, |
wxiaoguang
reviewed
Mar 7, 2025
| } | ||
|
|
||
| // Check that the path given in opts.treePath is valid (not a git path) | ||
| cleanTreePath := CleanUploadFileName(treePath) |
There was a problem hiding this comment.
It is not "uploading", why CleanUploadFileName?
wxiaoguang
reviewed
Mar 7, 2025
| return nil, err | ||
| } | ||
|
|
||
| // If the entry is a file, we return a FileContentResponse object |
There was a problem hiding this comment.
What is FileContentResponse object?
wxiaoguang
reviewed
Mar 7, 2025
| subTreePath := path.Join(treePath, e.Name()) | ||
|
|
||
| if strings.Contains(e.Name(), "/") { | ||
| mapTree[path.Dir(e.Name())] = append(mapTree[path.Dir(e.Name())], &TreeViewNode{ |
There was a problem hiding this comment.
Duplicate call to path.Dir
wxiaoguang
reviewed
Mar 7, 2025
Comment on lines
+316
to
+319
| // GetTreeInformation returns the first level directories and files and all the trees of the path to treePath. | ||
| // If treePath is a directory, list all subdirectories and files of treePath. | ||
| /* | ||
| Example 1: (path: /) |
There was a problem hiding this comment.
What's the difference from GetTreeList? The code is almost the same and the examples are copied?
wxiaoguang
reviewed
Mar 7, 2025
| } | ||
| var entries git.Entries | ||
| if recursive { | ||
| entries, err = gitTree.ListEntriesRecursiveFast() |
There was a problem hiding this comment.
It is inefficient for large repo
wxiaoguang
reviewed
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #29328
This pull request introduces a file tree on the left side when reviewing files of a repository.