-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Support Actions concurrency syntax
#32751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3551677 to
fcf4517
Compare
52833e7 to
130f2a2
Compare
461c7c1 to
d5168a2
Compare
e038ed2 to
f77f266
Compare
concurrency for Actionsconcurrency syntax
ad71599 to
8f5948b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
) Move the main logic of `generateTaskContext` and `findTaskNeeds` to the `services` layer. This is a part of #32751, since we need the git context and `needs` to parse the concurrency expressions. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
|
I have no more questions. If the new changes look good, feel free to merge. Thank you all. |
* giteaofficial/main: [skip ci] Updated translations via Crowdin Update JS deps, misc tweaks (go-gitea#35643) Bump actions/checkout to v5 (go-gitea#35644) nix flake update (go-gitea#35639) Cleanup ActionRun creation (go-gitea#35624) bump archives&rar dep (go-gitea#35637) Fix merge panic (go-gitea#35606) Bump happy-dom from 19.0.2 to 20.0.0 (go-gitea#35625) Refactor ActionRunJob parsing into a reusable function (go-gitea#35623) Fix code tag style problem and LFS view bug (go-gitea#35628) Support Actions `concurrency` syntax (go-gitea#32751) The status icon of the Action step is consistent with GitHub (go-gitea#35618) Mock external service in hcaptcha TestCaptcha (go-gitea#35604) Fix inputing review comment will remove reviewer (go-gitea#35591) [skip ci] Updated translations via Crowdin Fix diffpatch API endpoint (go-gitea#35610) Print PR-Title into tooltip for actions (go-gitea#35579)
|
@lunny Are there any considerations to backport this PR to 1.25 ? Thanks. |
|
IMO This is too large for backporting and changes the database structure |
Thanks for the response. Did 1.25.1 or earlier versions introduce any other setting or feature that would enable new workarounds to avoid ongoing pipelines being cancelled by new pushes? Ideally the jobs would queue, the concurrency syntax feature is secondary to me. |
|
1.25 won't get large changes. I think you can use the main-nightly, it should be stable enough for daily usage. And any bug will be fixed in first time. |
Fix #24769
Fix #32662
Fix #33260
Depends on https://gitea.com/gitea/act/pulls/124
This PR removes the auto-cancellation feature added by #25716. Users need to manually add
concurrencyto workflows to control concurrent workflows or jobs.