Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal server error when updating labels without write permission #32776

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Dec 10, 2024

Fix #32775

if permission denined, prepareForReplaceOrAdd will return nothing, and this case is not handled.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 10, 2024
@yp05327 yp05327 added the backport/v1.22 This PR should be backported to Gitea 1.22 label Dec 10, 2024
@yp05327 yp05327 added this to the 1.23.0 milestone Dec 10, 2024
@yp05327 yp05327 marked this pull request as draft December 10, 2024 05:10
@yp05327 yp05327 marked this pull request as ready for review December 10, 2024 05:16
@yp05327 yp05327 changed the title Fix internal server error when updating labels Fix internal server error when updating labels without write permission Dec 10, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 10, 2024
@lunny lunny enabled auto-merge (squash) December 10, 2024 18:17
@lunny lunny merged commit 2ac6f2b into go-gitea:main Dec 10, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 10, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Dec 10, 2024
* origin/main:
  Fix internal server error when updating labels without write permission (go-gitea#32776)
  Fix wiki ui (go-gitea#32781)
  Change typescript `module` to `nodenext` (go-gitea#32757)
  Refactor issue filter (labels, poster, assignee) (go-gitea#32771)
  Make RepoActionView.vue support `##[group]` (go-gitea#32770)
  [skip ci] Updated translations via Crowdin
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 10, 2024
…on (go-gitea#32776)

Fix go-gitea#32775

if permission denined, `prepareForReplaceOrAdd` will return nothing, and
this case is not handled.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 10, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 11, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Use batch database operations instead of one by one to optimze api pulls (go-gitea#32680)
  Fix internal server error when updating labels without write permission (go-gitea#32776)
  Fix wiki ui (go-gitea#32781)
  Change typescript `module` to `nodenext` (go-gitea#32757)
  Refactor issue filter (labels, poster, assignee) (go-gitea#32771)
@yp05327 yp05327 deleted the fix-32775 branch January 17, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

403 Forbidden Error when updating labels via REST API
4 participants