Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fixture loading for testing #33024

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Refactor fixture loading for testing #33024

merged 5 commits into from
Dec 30, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 28, 2024 •
edited
Loading

To help binary size and testing performance

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 28, 2024
@wxiaoguang wxiaoguang marked this pull request as draft December 28, 2024 15:11
@wxiaoguang wxiaoguang force-pushed the refactor-fixture branch 3 times, most recently from 5ffef9e to 9382f60 Compare December 28, 2024 16:05
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 28, 2024
@wxiaoguang wxiaoguang force-pushed the refactor-fixture branch 6 times, most recently from e326d00 to c078937 Compare December 28, 2024 17:37
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing backport/v1.23 This PR should be backported to Gitea 1.23 labels Dec 28, 2024
@wxiaoguang wxiaoguang marked this pull request as ready for review December 28, 2024 18:06
@wxiaoguang wxiaoguang marked this pull request as draft December 28, 2024 18:24
@wxiaoguang wxiaoguang force-pushed the refactor-fixture branch 4 times, most recently from d21ee6e to 67d2df7 Compare December 28, 2024 19:25
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Dec 28, 2024
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2024
@wxiaoguang wxiaoguang marked this pull request as ready for review December 29, 2024 05:47
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2024
Closed
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Dec 29, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2024
Merged
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Dec 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2024
@wxiaoguang wxiaoguang requested a review from delvh December 29, 2024 15:18
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@lunny lunny enabled auto-merge (squash) December 30, 2024 02:25
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@go-gitea go-gitea deleted a comment from GiteaBot Dec 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
lunny pushed a commit that referenced this pull request Dec 30, 2024
@wxiaoguang
Refactor testfixtures (#33028)
ce6a60a 
Partial backport of #33024
@lunny lunny merged commit dafadf0 into go-gitea:main Dec 30, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@wxiaoguang wxiaoguang deleted the refactor-fixture branch December 30, 2024 04:53
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8aaec8e 
* giteaofficial/main:
  Fix issue comment number (go-gitea#30556)
  Fix duplicate co-author in squashed merge commit messages (go-gitea#33020)
  Merge updatecommentattachment functions (go-gitea#33044)
  Move SetMerged to service layer (go-gitea#33045)
  Remove aws go sdk package dependency (go-gitea#33029)
  Fix settings not being loaded at CLI (go-gitea#26402)
  Refactor fixture loading for testing (go-gitea#33024)
  Use gitrepo.GetTreePathLatestCommit to get file lastest commit instead from latest commit cache (go-gitea#32987)
  Fix bug automerge cannot be chosed when there is only 1 merge style (go-gitea#33040)
  use `-s -w` ldflags for release artifacts (go-gitea#33041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code modifies/migrations size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @techknowlogick @GiteaBot