-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unset XDG_HOME_CONFIG as gitea manages configuration locations #33067
Conversation
adding error check to manage lint
c9bb2c4
to
c7eb088
Compare
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Is it better to move it closer to |
|
Hmm, find another case: |
good point,
|
This may impact let's encrypt as I believe certmagic uses xdg to store the certs. I think this is overridden, but I can't fully remember. Just putting this note here so I remember to check once I'm at a computer |
I do not think any user could start Gitea with XDG_HOME_CONFIG to provide services to other users. Have they manually written |
@lunny thanks for confirming:) |
* giteaofficial/main: [skip ci] Updated translations via Crowdin unset XDG_HOME_CONFIG as gitea manages configuration locations (go-gitea#33067) Refactor repo-new.ts (go-gitea#33070) Refactor pull-request compare&create page (go-gitea#33071) feat: link to nuget dependencies (go-gitea#26554) Remove some unnecessary template helpers (go-gitea#33069) Inherit submodules from template repository content (go-gitea#16237) [skip ci] Updated translations via Crowdin feat(action): issue change title notifications (go-gitea#33050) Use project's redirect url instead of composing url (go-gitea#33058) Fix unittest and repo create bug (go-gitea#33061) Fix locale type (go-gitea#33059) Refactor maven package registry (go-gitea#33049) Optimize the installation page (go-gitea#32994) [Feature] Private README.md for organization (go-gitea#32872) Make issue suggestion work for new PR page (go-gitea#33035) Add IntelliJ Gateway's .uuid to gitignore (go-gitea#33052)
unset XDG_CONFIG_HOME early to enable gitea to manage git configuration. simple error checking to satisfy the linting. Closes #33039