Skip to content

Clone button enhancements (#33362) #33404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Clone button enhancements (#33362) #33404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions web_src/css/modules/tippy.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
z-index: 1;
}

.tippy-box[data-theme="default"] {
box-shadow: 0 6px 18px var(--color-shadow);
}

/* bare theme, no styling at all, except box-shadow */
.tippy-box[data-theme="bare"] {
border: none;
Expand Down
2 changes: 1 addition & 1 deletion web_src/css/repo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,7 @@ td .commit-summary {
}

.repo-button-row-left {
flex: 1;
flex-grow: 1;
}

.repo-button-row .button {
Expand Down
4 changes: 3 additions & 1 deletion web_src/css/repo/clone.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@
.clone-panel-tab .item {
padding: 5px 10px;
background: none;
color: var(--color-text-light-2);
}

.clone-panel-tab .item.active {
border-bottom: 3px solid var(--color-secondary);
color: var(--color-text-dark);
border-bottom: 3px solid currentcolor;
}

.clone-panel-tab + .divider {
Expand Down
1 change: 1 addition & 0 deletions web_src/js/features/repo-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ function initClonePanelButton(btn: HTMLButtonElement) {
placement: 'bottom-end',
interactive: true,
hideOnClick: true,
arrow: false,
});
}

Expand Down
5 changes: 3 additions & 2 deletions web_src/js/modules/tippy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,17 @@ export function createTippy(target: Element, opts: TippyOpts = {}): Instance {
visibleInstances.add(instance);
return onShow?.(instance);
},
arrow: arrow || (theme === 'bare' ? false : arrowSvg),
arrow: arrow ?? (theme === 'bare' ? false : arrowSvg),
// HTML role attribute, ideally the default role would be "popover" but it does not exist
role: role || 'menu',
// CSS theme, either "default", "tooltip", "menu", "box-with-header" or "bare"
theme: theme || role || 'default',
offset: [0, arrow ? 10 : 6],
plugins: [followCursor],
...other,
} satisfies Partial<Props>);

if (role === 'menu') {
if (instance.props.role === 'menu') {
target.setAttribute('aria-haspopup', 'true');
}

Expand Down
Loading