Skip to content

Show info about maintainers are allowed to edit a PR #33738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

wxiaoguang
Copy link
Contributor

A simple and clear approach. The existing test TestPullCompare_EnableAllowEditsFromMaintainer should be good enough.

Fix #21280

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Feb 27, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Feb 27, 2025
@kuraga
Copy link

kuraga commented Feb 27, 2025

Thanks!

Will it show where to push?

@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 27, 2025
@wxiaoguang
Copy link
Contributor Author

Branch info is in the PR description

image

@kuraga
Copy link

kuraga commented Feb 27, 2025

As I remember, it's for the author only...
It might be pull/{PR_id} or similar...
Hm. Ok, I can be incorrect.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2025
@lunny lunny enabled auto-merge (squash) February 27, 2025 16:02
@lunny lunny merged commit 01156f9 into go-gitea:main Feb 27, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2025
@wxiaoguang wxiaoguang deleted the fix-show-maintainer-edit branch February 27, 2025 16:52
@kuraga
Copy link

kuraga commented Feb 27, 2025

@wxiaoguang ,could you, please make a PR at my https://demo.gitea.com/kuraga/test ? With Allow edits from maintainers on...

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 3, 2025
* giteaofficial/main:
  Use pullrequestlist instead of []*pullrequest (go-gitea#33765)
  Upgrade act to 0.261.4 and actions-proto-go to v0.4.1 (go-gitea#33760)
  Webhook add X-Gitea-Hook-Installation-Target-Type Header (go-gitea#33752)
  Fix dynamic content loading init problem (go-gitea#33748)
  [skip ci] Updated translations via Crowdin
  Add composor source field (go-gitea#33502)
  upgrade go-crypto from 1.1.5 to 1.1.6 (go-gitea#33745)
  Disable go license generation as part of `make tidy` (go-gitea#33747)
  Refactor repo-diff.ts (go-gitea#33746)
  Use `git diff-tree` for `DiffFileTree` on diff pages (go-gitea#33514)
  [skip ci] Updated translations via Crowdin
  Improve "generate new access token" form (go-gitea#33730)
  Remove superflous tw-content-center (go-gitea#33741)
  Clone repository with Tea CLI (go-gitea#33725)
  allow filtering /repos/{owner}/{repo}/pulls by target base branch queryparam (go-gitea#33684)
  Show info about maintainers are allowed to edit a PR (go-gitea#33738)
  Improve admin user view page (go-gitea#33735)
  [skip ci] Updated translations via Crowdin
  Align sidebar gears to the right (go-gitea#33721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show info if Maintainers are allowed to edit the Pull
6 participants