Skip to content

Add changelog for 1.23.5 #33780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2025
Merged

Add changelog for 1.23.5 #33780

merged 5 commits into from
Mar 4, 2025

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 3, 2025 •
edited
Loading

Wait tomorrow's Golang version.
Maybe wait backport of #33764 and #33744, #33789

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2025
@GiteaBot GiteaBot added this to the 1.23.5 milestone Mar 3, 2025
wxiaoguang
wxiaoguang approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO no need to wait for other PRs since this release contains security fixes. And TBH I don't feel safe to backport PRs which change logic a lot but are not able to have enough tests.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2025
metiftikci
metiftikci approved these changes Mar 4, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@lunny @metiftikci
Update CHANGELOG.md
bfb1e96 
Co-authored-by: metiftikci <metiftikci@hotmail.com>
@lunny lunny marked this pull request as ready for review March 4, 2025 19:47
@lunny lunny added the frontport/main This PR is not targeting the main branch. Still, its changes should also be added there label Mar 4, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@lunny lunny enabled auto-merge (squash) March 4, 2025 20:49
@lunny lunny merged commit 9c3511f into go-gitea:release/v1.23 Mar 4, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@lunny lunny deleted the lunny/release_note_1.23.5 branch March 4, 2025 20:58
@lunny lunny added the frontport/done The frontport PR has been created label Mar 5, 2025
@lunny lunny mentioned this pull request Mar 5, 2025
Merged
@wxiaoguang
Copy link
Contributor

-> Gitea 1.23.5 released with old Go version 1.23? #33806

lunny added a commit that referenced this pull request Mar 5, 2025
@lunny
Update changelog for v1.23.5 (#33797)
df7b61c 
frontport from #33780
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@metiftikci metiftikci metiftikci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

frontport/done The frontport PR has been created frontport/main This PR is not targeting the main branch. Still, its changes should also be added there lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs

Projects

None yet

Milestone

1.23.5

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @wxiaoguang @metiftikci @GiteaBot