Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix ACME (3rd) #33807

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Try to fix ACME (3rd) #33807

merged 2 commits into from
Mar 7, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33802, fix #32191

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Mar 5, 2025
This was referenced Mar 5, 2025
Merged
Closed
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 5, 2025
@wxiaoguang wxiaoguang requested a review from lunny March 6, 2025 23:01
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 7, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 7, 2025 00:56
@wxiaoguang wxiaoguang merged commit ef18655 into go-gitea:main Mar 7, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 7, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 7, 2025
@wxiaoguang wxiaoguang deleted the try-fix-acme-3 branch March 7, 2025 01:04
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 7, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
00442d2 
* giteaofficial/main:
  Use correct start and end commits for GetDiffTree (go-gitea#33816)
  Try to fix ACME (3rd) (go-gitea#33807)
  remove context from mail struct (go-gitea#33811)
wxiaoguang added a commit that referenced this pull request Mar 8, 2025
@wxiaoguang
Try to fix ACME (3rd) (#33807) (#33808)
16a3324 
Backport #33807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
4 participants
@wxiaoguang @lunny @delvh @GiteaBot