Fine tune push mirror UI #33866
Fine tune push mirror UI #33866
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
|
|
| @@ -203,8 +203,17 @@ | |||
| {{range .PushMirrors}} | |||
| <tr> | |||
| <td class="tw-break-anywhere">{{.RemoteAddress}}</td> | |||
| <td>{{ctx.Locale.Tr "repo.settings.mirror_settings.direction.push"}}</td> | |||
| <td>{{if .LastUpdateUnix}}{{DateUtils.FullTime .LastUpdateUnix}}{{else}}{{ctx.Locale.Tr "never"}}{{end}} {{if .LastError}}<div class="ui red label" data-tooltip-content="{{.LastError}}">{{ctx.Locale.Tr "error"}}</div>{{end}}</td> | |||
| <td>{{ctx.Locale.Tr "repo.settings.mirror_settings.direction.push"}} ({{.Interval}})</td> | |||
There was a problem hiding this comment.
Wouldn't it make more sense to include the interval already in the translated string?
There was a problem hiding this comment.
How to? See the screenshot, I do not see your point.
There was a problem hiding this comment.
And I think the current syntax is good for all languages, no need to make it more complex.
(If not good, it won't be late to add a new translation in a new PR)
There was a problem hiding this comment.
I meant something like Push (every %v), but yes, we can postpone it.
There was a problem hiding this comment.
Well, actually Push (every %v) is not really translatable ..... here 2h3m is not a human language, it doesn't fit "every" in many cases. 🤣
| <div class="field"> | ||
| <label for="name">{{ctx.Locale.Tr "repo.settings.mirror_settings.mirrored_repository"}}</label> | ||
| <div class="ui small input"> | ||
| <input id="push-mirror-edit-address" readonly> |
There was a problem hiding this comment.
This breaks changing the mirror URL.
At the moment (1.23.4), it is possible to change it.
There was a problem hiding this comment.
Are you sure? readonly, how to change the mirror URL?
There was a problem hiding this comment.
The related PRs are:
- Allow editing push mirrors after creation #26151
- Remove the mirror repo URL from edit form since it can't be changed #27487
The URL is not changeable.
There was a problem hiding this comment.
Yep, you are right, I got completely bamboozled:
I saw the readonly in the code above, but didn't check in the actual textbox if I could edit it.
The textbox did not look disabled, so I assumed it could be edited…
I thought the readonly may have been removed with JS.
I didn't imagine in the slightest that we would have a read-only input instead of a span that does not differ at all from an editable input.
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
* giteaofficial/main: Pull request updates will also trigger code owners review requests (go-gitea#33744) [skip ci] Updated translations via Crowdin remove context from retry downloader (go-gitea#33871) Fine tune push mirror UI (go-gitea#33866) Fix markdown render (go-gitea#33870) Improve issue & code search (go-gitea#33860)
No description provided.