Skip to content

Remove unused or abused styles #33918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Remove unused or abused styles #33918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/package/content/container.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
<tbody>
{{range $key, $value := .PackageDescriptor.Metadata.Labels}}
<tr>
<td class="top aligned">{{$key}}</td>
<td class="tw-align-top">{{$key}}</td>
<td class="tw-break-anywhere">{{$value}}</td>
</tr>
{{end}}
Expand Down
12 changes: 5 additions & 7 deletions templates/repo/issue/labels/label_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,11 @@

{{if and (not .PageIsOrgSettingsLabels) (.OrgLabels)}}
<li class="item">
<div class="ui grid middle aligned">
<div class="ten wide column">
{{ctx.Locale.Tr "repo.org_labels_desc"}}
{{if .IsOrganizationOwner}}
<a href="{{.OrganizationLink}}/settings/labels">({{ctx.Locale.Tr "repo.org_labels_desc_manage"}})</a>:
{{end}}
</div>
<div>{{/* parent is flex, so use block here to keep sentence spaces */}}
{{ctx.Locale.Tr "repo.org_labels_desc"}}
{{if .IsOrganizationOwner}}
<a href="{{.OrganizationLink}}/settings/labels">({{ctx.Locale.Tr "repo.org_labels_desc_manage"}})</a>:
{{end}}
</div>
</li>

Expand Down
10 changes: 4 additions & 6 deletions templates/repo/issue/sidebar/reference_link.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<div class="divider"></div>
<div class="ui equal width compact grid">
{{$issueReferenceLink := printf "%s#%d" .Issue.Repo.FullName .Issue.Index}}
<div class="row tw-items-center" data-tooltip-content="{{$issueReferenceLink}}">
<span class="text column truncate">{{ctx.Locale.Tr "repo.issues.reference_link" $issueReferenceLink}}</span>
<button class="ui two wide button column tw-p-2" data-clipboard-text="{{$issueReferenceLink}}">{{svg "octicon-copy" 14}}</button>
</div>
{{$issueReferenceLink := printf "%s#%d" .Issue.Repo.FullName .Issue.Index}}
<div class="flex-text-block" data-tooltip-content="{{$issueReferenceLink}}">
<span class="tw-flex-1 gt-ellipsis">{{ctx.Locale.Tr "repo.issues.reference_link" $issueReferenceLink}}</span>
<button class="ui compact tiny icon button" data-clipboard-text="{{$issueReferenceLink}}">{{svg "octicon-copy" 14}}</button>
</div>
2 changes: 1 addition & 1 deletion templates/user/settings/repos.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
{{end}}
{{else}}
{{if .Repos}}
<div class="ui middle aligned divided list">
<div class="ui list">
{{range .Repos}}
<div class="item">
<div class="content flex-text-block">
Expand Down
22 changes: 0 additions & 22 deletions web_src/css/modules/grid.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,28 +393,6 @@
margin-right: 2.5rem;
}

.ui[class*="middle aligned"].grid > .column:not(.row),
.ui[class*="middle aligned"].grid > .row > .column,
.ui.grid > [class*="middle aligned"].row > .column,
.ui.grid > [class*="middle aligned"].column:not(.row),
.ui.grid > .row > [class*="middle aligned"].column {
flex-direction: column;
vertical-align: middle;
align-self: center !important;
}

.ui[class*="equal width"].grid > .column:not(.row),
.ui[class*="equal width"].grid > .row > .column,
.ui.grid > [class*="equal width"].row > .column {
display: inline-block;
flex-grow: 1;
}
.ui[class*="equal width"].grid > .wide.column,
.ui[class*="equal width"].grid > .row > .wide.column,
.ui.grid > [class*="equal width"].row > .wide.column {
flex-grow: 0;
}

@media only screen and (max-width: 767.98px) {
.ui[class*="mobile reversed"].grid,
.ui[class*="mobile reversed"].grid > .row,
Expand Down
10 changes: 0 additions & 10 deletions web_src/css/modules/table.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,6 @@
}
}

.ui.table[class*="top aligned"],
.ui.table [class*="top aligned"] {
vertical-align: top;
}

.ui.table[class*="middle aligned"],
.ui.table [class*="middle aligned"] {
vertical-align: middle;
}

.ui.table th.collapsing,
.ui.table td.collapsing {
width: 1px;
Expand Down
10 changes: 0 additions & 10 deletions web_src/fomantic/build/components/form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,16 +1499,6 @@
width: 100%;
}

/*--------------------
Equal Width
---------------------*/

.ui[class*="equal width"].form .fields > .field,
.ui.form [class*="equal width"].fields > .field {
width: 100%;
flex: 1 1 auto;
}

/*--------------------
Inline Fields
---------------------*/
Expand Down
9 changes: 2 additions & 7 deletions web_src/fomantic/build/components/modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,7 @@
align-self: start;
max-width: 100%;
}
.ui.modal > [class*="top aligned"] {
align-self: start;
}
.ui.modal > [class*="middle aligned"] {
align-self: center;
}

.ui.modal > [class*="stretched"] {
align-self: stretch;
}
Expand Down Expand Up @@ -258,7 +253,7 @@
padding: 1rem 0 !important;
box-shadow: none;
}

/* Let Buttons Stack */
.ui.modal > .actions {
padding: 1rem 1rem 0rem !important;
Expand Down