Skip to content

Defer captcha script loading #33919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

Defer captcha script loading #33919

merged 3 commits into from
Mar 17, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33899

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 17, 2025
@wxiaoguang
Copy link
Contributor Author

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#defer

@wxiaoguang wxiaoguang mentioned this pull request Mar 17, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) March 17, 2025 14:44
@techknowlogick techknowlogick added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 17, 2025
@techknowlogick techknowlogick merged commit fdaf1cc into go-gitea:main Mar 17, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 17, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2025
@wxiaoguang wxiaoguang deleted the fix-script-load branch March 17, 2025 15:24
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
afce5d2 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Optimize Layout Styles of Filelist (go-gitea#33920)
  [skip ci] Updated translations via Crowdin
  update go version for devcontainers (go-gitea#33923)
  Added Description Field for Secrets and Variables  (go-gitea#33526)
  Try to figure out attribute checker problem (go-gitea#33901)
  Defer captcha script loading (go-gitea#33919)
  Fix file tree issues (go-gitea#33916)
  Remove unused or abused styles (go-gitea#33918)
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Apr 1, 2025
@wxiaoguang @Gusted
Defer captcha script loading (go-gitea#33919)
839739f 
Fix go-gitea#33899

(cherry picked from commit fdaf1cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

When opening the login interface for the first time, the login box is very narrow and then returns to normal.
6 participants
@wxiaoguang @lunny @silverwind @hiifong @techknowlogick @GiteaBot