Fix some migration and repo name problems #33986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
|
lunny
approved these changes
Mar 23, 2025
GiteaBot
added
lgtm/need 1
hiifong
reviewed
Mar 25, 2025
| test('sanitizeRepoName', () => { | ||
| expect(sanitizeRepoName(' a b ')).toEqual('a-b'); | ||
| expect(sanitizeRepoName('a-b_c.git ')).toEqual('a-b_c'); | ||
| expect(sanitizeRepoName('/x.git/')).toEqual('-x.git-'); |
There was a problem hiding this comment.
For cases where the repo name starts or ends with '/', I think it's better to just remove it
There was a problem hiding this comment.
Thanks for the suggestion. Actually in my mind we don't need to make it more complex than it should be.
The sanitizeRepoName only needs to make the name overall good, but doesn't need to do too much for end users. For example: there are far more edge cases: \hello\world, @asdf, etc
hiifong
approved these changes
Mar 25, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 26, 2025
* giteaofficial/main: Enable color output in govulncheck (go-gitea#34012) Update Makefile test comments (go-gitea#34013) Move duplicated functions (go-gitea#33977) Git client will follow 301 but 307 (go-gitea#34005) Prepare common tmpl functions in a middleware (go-gitea#33957) Update go mod dependencies (go-gitea#33988) Fix some migration and repo name problems (go-gitea#33986) [skip ci] Updated translations via Crowdin Use filepath.Join instead of path.Join for file system file operations (go-gitea#33978) Add changelog for 1.23.6 (go-gitea#33975) Fix incorrect code search indexer options (go-gitea#33992) Auto expand "New PR" form (go-gitea#33971) Move ParseBool to optional (go-gitea#33979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnmarshalHandleDoubleEncodestateEvent.Userin gitlab migrationreleaseandwikiunits when they are selected in migration