-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Use run-name and evaluate workflow variables #34301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
badhezi
wants to merge
27
commits into
go-gitea:main
Choose a base branch
from
badhezi:dev/hezi/fix-run-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't this go to jobparser? |
@TheFox0x7 |
cca335d
to
9408c76
Compare
…order DispatchActionWorkflow to support run-name parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
modifies/dependencies
modifies/go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #34247
depends on https://gitea.com/gitea/act/pulls/136
I couldn't find any previous implementation for
run-name
support on workflows so I created one.Key points:
All dispatched workflows, scheduled workflows and detected workflows (from different hooks) will use and evaluate
run-name
if exists, with the corresponding gitea context and variables. This will be used as the Action run title and replace the default commit message being used today.Had to change act package jobparser (see link above)
and create two helpers
gitea/models/actions/utils.go
Line 86 in 3a1320c
and
gitea/services/actions/context.go
Line 169 in 3a1320c
to pass the correct types to GenerateGiteaContext and WithGitContext respectively.