Fix http auth header parsing #34936
Merged
Fix http auth header parsing #34936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-string-equal
branch
from
9ad13dd to
c30c9c3
Compare
lunny
approved these changes
Jul 3, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
fix-string-equal
branch
from
c30c9c3 to
7559a08
Compare
wxiaoguang
force-pushed
the
fix-string-equal
branch
from
7559a08 to
b38e25b
Compare
hiifong
approved these changes
Jul 3, 2025
GiteaBot
added
lgtm/done
hiifong
reviewed
Jul 3, 2025
services/lfs/server.go
Outdated
| fallthrough | ||
| case "token": | ||
| return handleLFSToken(ctx, tokenSHA, target, mode) | ||
| token, ok := httpauth.ParseAuthorizationHeaderBearerToken(authorization) |
There was a problem hiding this comment.
ref：The Git LFS API uses HTTP Basic Authentication to authorize requests.
I'm not sure, would there be any other issues with us using token?
There was a problem hiding this comment.
That "basic" is not this "basic"
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 4, 2025
* giteaofficial/main: Fix http auth header parsing (go-gitea#34936) Don't send trigger for a pending review's comment create/update/delete (go-gitea#34928) Support getting last commit message using contents-ext API (go-gitea#34904) [skip ci] Updated translations via Crowdin Exclude devtest.ts from tailwindcss (go-gitea#34935)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
strings.EqualFoldis wrong in many cases.