Fix submodule parsing when the gitmodules is missing (#35109) #35118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up go-gitea#35096, fix go-gitea#35095, fix go-gitea#35115 and add more tests The old code used some fragile behaviors which depend on the "nil" receiver. This PR should be a complete fix for more edge cases.
GiteaBot
added
modifies/go
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Jul 18, 2025
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Jul 18, 2025
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #35109 by wxiaoguang
Follow up #35096, fix #35095, fix #35115 and add more tests
The old code used some fragile behaviors which depend on the "nil" receiver. This PR should be a complete fix for more edge cases.