Skip to content

Allow deleting comment with content via API like web did #35346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2025
Merged

Allow deleting comment with content via API like web did #35346

merged 2 commits into from
Aug 25, 2025

Conversation

@lunny
Copy link
Member

@lunny lunny commented Aug 23, 2025

Fix #35296

@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Aug 23, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 23, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Aug 23, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 25, 2025
@lafriks lafriks enabled auto-merge (squash) August 25, 2025 10:16
@lafriks lafriks merged commit c4fbccc into go-gitea:main Aug 25, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Aug 25, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Aug 25, 2025
@lunny @GiteaBot
Allow deleting comment with content via API like web did (go-gitea#35346
f65f636 
)

Fix go-gitea#35296
@GiteaBot GiteaBot mentioned this pull request Aug 25, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Aug 25, 2025
lunny added a commit that referenced this pull request Aug 25, 2025
@GiteaBot @lunny
Allow deleting comment with content via API like web did (#35346) (#3…
cbc595b 
…5354)

Backport #35346 by @lunny

Fix #35296

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@lunny lunny deleted the lunny/allow_delete_content_comment_api branch August 25, 2025 16:29
lyricwulf pushed a commit to lyricwulf/gitea that referenced this pull request Aug 25, 2025
@lunny @lyricwulf
Allow deleting comment with content via API like web did (go-gitea#35346
e100c4e 
)

Fix go-gitea#35296
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 28, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
553f2da 
* giteaofficial/main:
  Remove incorrect "db.DefaultContext" usages (go-gitea#35366)
  Refactor to use reflect.TypeFor (go-gitea#35370)
  [skip ci] Updated translations via Crowdin
  Remove wrong "git.DefaultContext" (go-gitea#35364)
  Fix context usages (go-gitea#35348)
  Instance signing rule `pubkey` should allow all public keys, not just GPG (go-gitea#35357)
  Allow deleting comment with content via API like web did (go-gitea#35346)
hiifong added a commit to hiifong/gitea that referenced this pull request Aug 31, 2025
@hiifong
Merge branch 'main' into squash-merge-msg
4a0796a 
* main: (34 commits)
  when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267)
  [skip ci] Updated translations via Crowdin
  Upgrade xz to v0.5.15 (go-gitea#35377)
  Refactor db package (go-gitea#35380)
  Remove the duplicated function GetTags (go-gitea#35375)
  [skip ci] Updated translations via Crowdin
  Allow foreachref parser to grow its buffer (go-gitea#35365)
  Remove global context from db package (go-gitea#35371)
  Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911)
  Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360)
  Remove incorrect "db.DefaultContext" usages (go-gitea#35366)
  Refactor to use reflect.TypeFor (go-gitea#35370)
  [skip ci] Updated translations via Crowdin
  Remove wrong "git.DefaultContext" (go-gitea#35364)
  Fix context usages (go-gitea#35348)
  Instance signing rule `pubkey` should allow all public keys, not just GPG (go-gitea#35357)
  Allow deleting comment with content via API like web did (go-gitea#35346)
  Prevent duplicate actions email (go-gitea#35215)
  rename nightly docker tag for main branch (go-gitea#35344)
  Fix atom/rss mixed error (go-gitea#35345)
  ...

# Conflicts:
#	tests/integration/pull_merge_test.go
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@kemzeb kemzeb kemzeb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

API when deleting review comment by ID reports 204 status but comment is not deleted

5 participants

@lunny @lafriks @delvh @kemzeb @GiteaBot