Pull Request Merge Text should exclude dismissed reviews if only official once count #35500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Sep 16, 2025
|
tests for this change are in #33356 |
|
I’m a bit confused about why we don’t always exclude dismissed reviewers. It would also be better to include the related tests in this PR. |
me too but you requested to debate it -> #33356 (comment)
the related pull is just a bugfix no function change ... so to have base tests there is better - and if that got merged i have to change them again to match the new behavior wicht then kan be in this pull i dont want to resolve conflicts again and again ... |
|
so yes the tests will be in this pull as diff as soon as the other pull is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #33356 (comment)