-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Make debian package setup example more self explained #35564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'd make the variables uppercase, this is a common practice in shell scripts. For the variables I would do: DISTRIBUTION="alpine" # "alpine", "other", "another"
COMPONENT="edge" # "edge", "other", "another" The benefit is the script will work when copied, and it should be obvious what the options are. Also, it'd be nice if we could syntax-highlight these instructions as bash, but doesn't have to be this PR. |
Signed-off-by: 6543 <6543@obermui.de>
Signed-off-by: 6543 <6543@obermui.de>
Can you remove the two |
remaining comments? what exactly do you propose, sorry dont get it rigt now :/ |
Co-authored-by: silverwind <me@silverwind.io> Signed-off-by: 6543 <6543@obermui.de>
As most users just copy the example code and the wonder why it did not work ... befor even thinking the shell vars in the example need to be filled with the info below ... just show them. and if there is no selection just return the only options directly
Screnshots outdated
multible
only one option available
mixed