Update golangci-lint to v2.6.0

[silverwind]

https://github.com/golangci/golangci-lint/releases/tag/v2.6.0

• modernize linter is enabled, this is the same as gopls modernize
• perfsprint linter is disabled because it conflicts with modernize (maybe there is a middle ground)
• gocritic deprecatedComment is disabled as it conflicts with go-swagger

[silverwind]

I think I will revert these string builder changes and disable the offending rule, it seems useless.

[silverwind]

The stringsbuilder rule is from modernize actually:

https://github.com/golang/tools/blob/ed067b1f257070c651750130ce5081e4afc1915f/gopls/doc/analyzers.md#stringsbuilder-replace--with-stringsbuilder

It says "This avoids quadratic memory allocation and improves performance." so maybe it is worth it.

I will fix those var names.

[silverwind]

I manually cleaned up the stringsbuilder cases, should be ready.

[wxiaoguang]

I really dislike unnecessary lint rules.

And I have strong objection for this Sprintf change, it doesn't improve readability.

[silverwind]

I think we could disable stringsbuilder in modernize if it's deemed useless. I guess the "quadratic" aspect of it would only be noticed with a sufficient iteration count. Also I think it's inherently golang's fault if string concatenation is O(n^2) instead of O(n) or O(1) complexity.

[silverwind]

I've disabled modernize.stringsbuilder and perfsprint.concat-loop so string concatenation in loops is allowed again and the diff is much reduced.

[silverwind]

The previous autofixes with the ugly var names were from perfsprint. When I try modernize's autofix, it does at least leave the var names intact, so if I enable stringsbuilder it produces a diff like this:

diff --git i/modules/git/foreachref/format.go w/modules/git/foreachref/format.go
index d9573a55d6..d2f9998fe8 100644
--- i/modules/git/foreachref/format.go
+++ w/modules/git/foreachref/format.go
@@ -74,10 +74,10 @@ func (f Format) Parser(r io.Reader) *Parser {

 // hexEscaped produces hex-escpaed characters from a string. For example, "\n\0"
 // would turn into "%0a%00".
 func (f Format) hexEscaped(delim []byte) string {
-	escaped := ""
+	var escaped strings.Builder
 	for i := range delim {
-		escaped += "%" + hex.EncodeToString([]byte{delim[i]})
+		escaped.WriteString("%" + hex.EncodeToString([]byte{delim[i]}))
 	}
-	return escaped
+	return escaped.String()
 }

Would that be an acceptable fix?

[silverwind]

I've re-enabled the modernize rule and ran make lint-go-fix, it looks acceptable imho, if not, revert the last commit.

[silverwind]

Actually, I've reverted, we can discuss the merits of stringsbuilder another time, let's merge this first.