-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write to log NoCommitterAccount #3621
Conversation
It's way too verbose, and the information is also printed to the user already. Fixes #3602.
Codecov Report
@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
- Coverage 36.15% 36.14% -0.01%
==========================================
Files 285 285
Lines 40921 40924 +3
==========================================
Hits 14794 14794
- Misses 23953 23957 +4
+ Partials 2174 2173 -1
Continue to review full report at Codecov.
|
@thehowl You should determine if the |
Done. |
@thehowl there is a function could do that. see https://github.com/thehowl/gitea/blob/f42e2d4771b8d158a7dbb8ec5ab34ffa4e7e1893/models/error.go#L84 |
Refresh the change set ;). I remembered immediately after I committed |
LGTM |
It's way too verbose, and the information is also printed to the user
already. Fixes #3602.