Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go vet error #3740

Merged
merged 2 commits into from
Mar 29, 2018
Merged

fix go vet error #3740

merged 2 commits into from
Mar 29, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 29, 2018

As title.

@lunny lunny added this to the 1.5.0 milestone Mar 29, 2018
@codecov-io
Copy link

codecov-io commented Mar 29, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1c5cbc3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3740   +/-   ##
========================================
  Coverage          ?   22.9%           
========================================
  Files             ?     124           
  Lines             ?   24755           
  Branches          ?       0           
========================================
  Hits              ?    5669           
  Misses            ?   18223           
  Partials          ?     863

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5cbc3...929c2b7. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2018
@lunny lunny merged commit 45d1fc0 into go-gitea:master Mar 29, 2018
@lunny lunny deleted the lunny/fix_vet branch March 29, 2018 23:21
lunny added a commit to lunny/gitea that referenced this pull request Mar 30, 2018
@lunny
fix go vet error (go-gitea#3740)
1b006ac
@lunny lunny mentioned this pull request Mar 30, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 30, 2018
lafriks pushed a commit that referenced this pull request Mar 30, 2018
@lunny @lafriks
fix go vet error (#3740) (#3744)
6c6d1ff
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @appleboy @jonasfranz @tboerger