Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path cleanup in multiple places #3871

Merged
merged 1 commit into from
May 1, 2018
Merged

Fix path cleanup in multiple places #3871

merged 1 commit into from
May 1, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Apr 30, 2018

As title

@lafriks lafriks added type/bug topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.4 labels Apr 30, 2018
@lafriks lafriks added this to the 1.5.0 milestone Apr 30, 2018
@codecov-io
Copy link

codecov-io commented May 1, 2018 •
edited
Loading

Codecov Report

Merging #3871 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3871   +/-   ##
=======================================
  Coverage   20.22%   20.22%           
=======================================
  Files         145      145           
  Lines       28997    28997           
=======================================
  Hits         5864     5864           
  Misses      22242    22242           
  Partials      891      891
Impacted Files Coverage Δ
models/repo.go 17.32% <0%> (ø) ⬆️
routers/repo/editor.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff022e...61d8616. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2018
@thehowl
Copy link
Contributor

thehowl commented May 1, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2018
@appleboy appleboy merged commit 181b3a8 into go-gitea:master May 1, 2018
@lafriks lafriks deleted the fix/path_cleanup branch May 1, 2018 07:49
lafriks added a commit to lafriks-fork/gitea that referenced this pull request May 1, 2018
@lafriks
Fix path cleanup in multiple places (go-gitea#3871)
b8c0c46
@lafriks lafriks mentioned this pull request May 1, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label May 1, 2018
appleboy pushed a commit that referenced this pull request May 1, 2018
@lafriks @appleboy
Fix path cleanup in multiple places (#3871) (#3873)
15cdb19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @thehowl @appleboy @bkcsoft