Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "error" as reserved username #3882

Merged
merged 2 commits into from
May 2, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 2, 2018

It is already used in code in multiple places (ex mustOwner function that returns owner name "error" when owner can not be loaded), so it should be added as reserved not to have problems at some point

@lafriks lafriks added this to the 1.5.0 milestone May 2, 2018
@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #3882 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3882      +/-   ##
==========================================
- Coverage   20.18%   20.17%   -0.02%     
==========================================
  Files         145      145              
  Lines       29151    29151              
==========================================
- Hits         5883     5880       -3     
- Misses      22374    22376       +2     
- Partials      894      895       +1
Impacted Files Coverage Δ
models/user.go 23.49% <ø> (ø) ⬆️
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 954e69f...bdf5385. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2018
@lunny
Copy link
Member

lunny commented May 2, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2018
@lafriks lafriks merged commit 9495429 into go-gitea:master May 2, 2018
@lafriks lafriks deleted the fix/add_reserved_error branch May 2, 2018 08:06
lafriks added a commit to lafriks-fork/gitea that referenced this pull request May 2, 2018
@lafriks lafriks added the backport/done All backports for this PR have been created label May 2, 2018
lafriks added a commit that referenced this pull request May 2, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants