Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue deadline not showing on issue page #3930

Merged
merged 4 commits into from
May 10, 2018
Merged

Fixed issue deadline not showing on issue page #3930

merged 4 commits into from
May 10, 2018

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented May 9, 2018 •
edited
Loading

Partially fixes #3922.

@kolaente kolaente mentioned this pull request May 9, 2018
Closed
7 tasks
@daviian
Copy link
Member

daviian commented May 9, 2018

Should we generally prohibit due dates in the past? What do you say?

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2018
@codecov-io
Copy link

codecov-io commented May 9, 2018 •
edited
Loading

Codecov Report

Merging #3930 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3930   +/-   ##
=======================================
  Coverage   20.27%   20.27%           
=======================================
  Files         146      146           
  Lines       29316    29316           
=======================================
  Hits         5945     5945           
  Misses      22470    22470           
  Partials      901      901

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce79145...8ca968e. Read the comment docs.

@kolaente
Copy link
Member Author

kolaente commented May 9, 2018

@daviian Speaking from my experience, no. I admit probably noone will set a duedate prior to 1970, but at my company we sometimes have to set deadlines to like yesterday or one wwek ago.

@daviian
Copy link
Member

daviian commented May 9, 2018

@kolaente Ok if thats the case then guess the fix is fine for me 👍

lafriks
lafriks approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky but I don't know anything better to recommend :)

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2018
daviian
daviian suggested changes May 9, 2018
View reviewed changes
templates/repo/issue/view_content/sidebar.tmpl Outdated
@@ -229,12 +229,12 @@
{{end}}

{{if and .IsSigned .IsRepositoryWriter}}
<form method="POST"{{if gt .Issue.DeadlineUnix 0}}style="display: none;"{{end}}} id="add_deadline_form" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/deadline/update" class="ui action input fluid">
<form method="POST"{{if ne.Issue.DeadlineUnix 0}}style="display: none;"{{end}}} id="add_deadline_form" action="{{$.RepoLink}}/issues/{{.Issue.Index}}/deadline/update" class="ui action input fluid">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space ;)

templates/repo/issue/view_content/sidebar.tmpl Outdated
{{$.CsrfTokenHtml}}
<div class="ui fluid action input">
<input required placeholder="{{.i18n.Tr "repo.issues.due_date_form"}}" {{if gt .Issue.DeadlineUnix 0}}value="{{.Issue.DeadlineUnix.Format "2006-01-02"}}"{{end}} type="date" name="date" style="min-width: 13.9rem;border-radius: 4px 0 0 4px;border-right: 0;white-space: nowrap;">
<input required placeholder="{{.i18n.Tr "repo.issues.due_date_form"}}" {{if ne.Issue.DeadlineUnix 0}}value="{{.Issue.DeadlineUnix.Format "2006-01-02"}}"{{end}} type="date" name="date" style="min-width: 13.9rem;border-radius: 4px 0 0 4px;border-right: 0;white-space: nowrap;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

templates/repo/issue/view_content/sidebar.tmpl Outdated
<button class="ui green icon button">
{{if gt .Issue.DeadlineUnix 0}}
{{if ne.Issue.DeadlineUnix 0}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2018
@lunny lunny added the type/bug label May 10, 2018
@lunny lunny added this to the 1.5.0 milestone May 10, 2018
@lafriks lafriks merged commit 60424b7 into go-gitea:master May 10, 2018
@kolaente kolaente deleted the fix-issue-deadline-not-showing branch May 10, 2018 11:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@daviian daviian daviian approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Issue 'due date' format checking / 500 ISE
6 participants
@kolaente @daviian @codecov-io @lafriks @lunny @bkcsoft