Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented May 22, 2018

Fix a bug intorduced by me in #3991 since xgo image doesn't seems to have gopath/bin folder in path.
So I add $GOPATH/bin to PATH for make releases

For reference : https://github.com/karalabe/xgo/blob/master/docker/base/Dockerfile

Needed to access go tool gxz
@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@45f3d4a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4020   +/-   ##
=========================================
  Coverage          ?   20.05%           
=========================================
  Files             ?      153           
  Lines             ?    30344           
  Branches          ?        0           
=========================================
  Hits              ?     6086           
  Misses            ?    23345           
  Partials          ?      913

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f3d4a...7873f89. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 22, 2018
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 22, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2018
@techknowlogick techknowlogick merged commit 6f31911 into go-gitea:master May 22, 2018
@sapk sapk deleted the fix-make-compress-in-ci branch May 22, 2018 17:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants