Fix relative markdown links with anchors #4058
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case Signed-off-by: Jonas Franz <info@jonasfranz.software>
Codecov Report
@@ Coverage Diff @@
## master #4058 +/- ##
==========================================
+ Coverage 19.96% 19.97% +0.01%
==========================================
Files 153 153
Lines 30482 30491 +9
==========================================
+ Hits 6086 6091 +5
- Misses 23483 23486 +3
- Partials 913 914 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
sapk
suggested changes
May 27, 2018
There was a problem hiding this comment.
Please use https://golang.org/pkg/net/url/#URL.ResolveReference .
As it is the recommended way to do it.
|
@sapk If I use |
|
@JonasFranzDEV Only relative one are failing https://play.golang.org/p/kk0OHdtTg0i |
|
And this could easely be check by u.IsAbs() |
Signed-off-by: Jonas Franz <info@jonasfranz.software>
sapk
approved these changes
May 28, 2018
bkcsoft
added
lgtm/need 1
techknowlogick
approved these changes
May 29, 2018
bkcsoft
added
lgtm/done
|
@JonasFranzDEV please send back port to release/v1.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3784
This is not the most elegant solution but it works.