Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow markdown table to scroll #4401

Merged
merged 5 commits into from
Jan 21, 2019
Merged

Allow markdown table to scroll #4401

merged 5 commits into from
Jan 21, 2019

Conversation

pgodwin
Copy link
Contributor

@pgodwin pgodwin commented Jul 9, 2018

overflow:auto isn't effective when a table is wider than the container. Adding display:block fixes this issue.

pgodwin and others added 2 commits July 9, 2018 16:12
@pgodwin
Allow markdown table to scroll
3731214 
`overflow:auto` isn't effective when a table is wider than the container. Adding `display:block` fixes this issue.
@pgodwin
Update index.css
68b43a5
@codecov-io
Copy link

codecov-io commented Jul 9, 2018 •
edited
Loading

Codecov Report

Merging #4401 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4401      +/-   ##
==========================================
+ Coverage   37.72%   37.73%   +0.01%     
==========================================
  Files         327      327              
  Lines       47866    47866              
==========================================
+ Hits        18056    18061       +5     
+ Misses      27212    27208       -4     
+ Partials     2598     2597       -1
Impacted Files Coverage Δ
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1fcd6b...39856de. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2018
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jul 9, 2018
@lafriks
Copy link
Member

lafriks commented Jul 10, 2018

can you give screenshots with before and after?

@pgodwin
Copy link
Contributor Author

pgodwin commented Jul 10, 2018

No worries.

I should point out that this is on Firefox 61 under Windows.

Before:

table block before

After:

table block after

@lafriks lafriks added this to the 1.6.0 milestone Jul 10, 2018
techknowlogick
techknowlogick approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict, but otherwise LGTM.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2018
@adelowo adelowo mentioned this pull request Aug 21, 2018
Closed
7 tasks
@lafriks
Copy link
Member

lafriks commented Aug 21, 2018

@pgodwin please resolve conflict

@techknowlogick techknowlogick modified the milestones: 1.6.0, 1.7.0 Sep 3, 2018
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@techknowlogick
Copy link
Member

@lafriks conflict resolved.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2019
@lafriks
Copy link
Member

lafriks commented Jan 21, 2019

Hopefully it does not have side effects :)

@techknowlogick techknowlogick merged commit 832bf21 into go-gitea:master Jan 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pgodwin @codecov-io @lafriks @techknowlogick @lunny @bkcsoft