Fixed bug where team with admin privelege type doesn't get any unit

[adelowo]

Fixes #4713

It turns out in the database team_units , the team units are not being stored in the db when the t.Authorize is of type AccessModeAdmin... There is a for loop that makes a slice of units but that for loop never runs because ( take x to be AccessModeAdmin ( from

gitea/models/access.go

Line 41 in f24ba27

func ParseAccessMode(permission string) AccessMode {

) x < AccessModeAdmin would then equal false.

[codecov-io]

Codecov Report

Merging #4719 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4719   +/-   ##
======================================
  Coverage    20.7%   20.7%           
======================================
  Files         167     167           
  Lines       32374   32374           
======================================
  Hits         6702    6702           
  Misses      24691   24691           
  Partials      981     981

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05dcfcf...bebd25d. Read the comment docs.

[lunny]

LGTM

[lunny]

I think this PR maybe wrong and need revert. Discuss:
For a single repo, AccessModeAdmin is a collaboration permission, it can do anything except transfer repo to others, remove the owners who has AccessModeOwner permission.
For an organization, the organization creator should have AccessModeOwner and a team has AccessModeOwner who is equal toAccessModeAdmin. So we should only use AccessModeAdmin on team.

[adelowo]

@lunny Yes, I opened #4772 afterward as a revert. As this was not the right fix