Fix Swagger JSON autogeneration issues. #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
+ Coverage 37.4% 37.43% +0.03%
==========================================
Files 308 308
Lines 45612 45711 +99
==========================================
+ Hits 17060 17113 +53
- Misses 26095 26138 +43
- Partials 2457 2460 +3
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
f617ff1 to
f5f2cbe
Compare
|
I remember the opposite problem with go version of swagger but since CI doesn't seems to complain. LGTM |
bkcsoft
added
lgtm/need 1
sapk
approved these changes
Sep 18, 2018
lafriks
approved these changes
Sep 18, 2018
bkcsoft
added
lgtm/done
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
3 times, most recently
from
bdf7f2c to
0ffd663
Compare
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
0ffd663 to
5bf3306
Compare
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
273541b to
b76928a
Compare
Remove unnecessary schema references for the forbidden and empty responses Signed-off-by: Andrew Thornton <art27@cantab.net>
|
My fixes for the CreateAccessToken are only partial see #5126. It's not obvious where the setting for AccessToken going in to the header is set. |
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
b76928a to
ad17f7d
Compare
|
Most of the swagger api descriptions incorrectly use the integer type when the underlying go code actually uses int64. I've added further changes to account for this. |
|
I've also noted that the swagger description of GET /repos/{owner}/{repo}/pulls was also inadequate |
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
fb9d4cf to
c232452
Compare
zeripath
added a commit
to zeripath/java-gitea-api
that referenced
this pull request
Oct 20, 2018
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
c232452 to
aefbac0
Compare
lunny
requested changes
Oct 20, 2018
Set int64 format for those which are int64 Some more form fixes
zeripath
force-pushed
the
swagger-json-autogeneration-fixes
branch
from
aefbac0 to
d7e86e6
Compare
|
@lunny need your approval |
zeripath
added a commit
to zeripath/java-gitea-api
that referenced
this pull request
Oct 20, 2018
lunny
approved these changes
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autogenerating a swager client from the current swagger.v1.json, at least in Java, there is an issue whereby the use of schema references for the forbidden and empty responses leads to a broken client being created due to swagger believing that these represent an unspecified object. This pull requests removes these unnecessary schema references for the API references where a description for the empty/forbidden responses is provided.