-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show email if the authenticated user owns the profile page being requested for #4981
Merged
techknowlogick
merged 12 commits into
go-gitea:master
from
adelowo:dont_hide_email_from_self
Feb 19, 2019
Merged
Show email if the authenticated user owns the profile page being requested for #4981
techknowlogick
merged 12 commits into
go-gitea:master
from
adelowo:dont_hide_email_from_self
Feb 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
reviewed
Sep 26, 2018
bkcsoft
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 26, 2018
adelowo
force-pushed
the
dont_hide_email_from_self
branch
from
September 27, 2018 20:19
4624ff7
to
2ad366c
Compare
requested for. Also removed `setting.UI.ShowUserEmail` as it's documentation says it only controls the email setting on the explore page
…ned in before ctx.User is called
adelowo
force-pushed
the
dont_hide_email_from_self
branch
from
December 9, 2018 17:29
55c578e
to
d09b47d
Compare
Will sure do this over the new week |
Codecov Report
@@ Coverage Diff @@
## master #4981 +/- ##
==========================================
+ Coverage 38.84% 38.86% +0.02%
==========================================
Files 349 349
Lines 49801 49801
==========================================
+ Hits 19344 19354 +10
+ Misses 27657 27646 -11
- Partials 2800 2801 +1
Continue to review full report at Codecov.
|
lafriks
approved these changes
Feb 19, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 19, 2019
techknowlogick
approved these changes
Feb 19, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed
setting.UI.ShowUserEmail
as it's documentation says itonly controls the email setting on the explore page