Skip to content

[website] file rendering through external binaries #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2018
Merged

[website] file rendering through external binaries #5387

merged 3 commits into from
Nov 23, 2018

Conversation

juanpablo-santos
Copy link
Contributor

New documentation section describing how to use external binaries for custom files rendering. Should fix #3758

@juanpablo-santos juanpablo-santos mentioned this pull request Nov 23, 2018
Closed
6 tasks
@codecov-io
Copy link

codecov-io commented Nov 23, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6467934). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5387   +/-   ##
=========================================
  Coverage          ?   37.44%           
=========================================
  Files             ?      312           
  Lines             ?    46507           
  Branches          ?        0           
=========================================
  Hits              ?    17414           
  Misses            ?    26601           
  Partials          ?     2492

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6467934...1a79b10. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2018
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Nov 23, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 23, 2018
techknowlogick
techknowlogick approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR 😄

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 23, 2018
@techknowlogick techknowlogick merged commit 49d9900 into go-gitea:master Nov 23, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wish: document external renderers support on website
6 participants
@juanpablo-santos @codecov-io @lunny @techknowlogick @lafriks @bkcsoft