Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #5525 Fix the Let's Encrypt handler #5527

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Backport #5525 Fix the Let's Encrypt handler #5527

merged 1 commit into from
Dec 11, 2018

Conversation

gregkare
Copy link
Contributor

@gregkare gregkare commented Dec 11, 2018 •
edited
Loading

  • Fix the Let's Encrypt handler by listening on a valid address

Also handle errors in the HTTP server go routine, return a fatal error
when something goes wrong.

Thanks to @gbl08ma for finding the actual bug

Here is an example of the error handling:

2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to
start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind:
permission denied

Closes #5280

  • Fix a typo

@gregkare
Backported go-gitea#5525 Fix the Let's Encrypt handler
6bd18b6 
* Fix the Let's Encrypt handler by listening on a valid address

Also handle errors in the HTTP server go routine, return a fatal error
when something goes wrong.

Thanks to @gbl08ma for finding the actual bug

Here is an example of the error handling:

    2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to
    start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind:
    permission denied

Closes go-gitea#5280

* Fix a typo
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@techknowlogick techknowlogick merged commit 716c291 into go-gitea:release/v1.6 Dec 11, 2018
@lafriks lafriks added this to the 1.6.2 milestone Dec 11, 2018
@gregkare gregkare deleted the release/v1.6 branch December 12, 2018 09:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bwko Bwko Bwko approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@gregkare @techknowlogick @Bwko @lafriks @bkcsoft