Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't list an issue on its own dependency list UI. #5658

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

HarshitOnGitHub
Copy link
Contributor

We need to disable the cache here otherwise we keep listing the issues even after they get closed.

Fixes: #4684.

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #5658 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5658      +/-   ##
==========================================
- Coverage   37.79%   37.76%   -0.03%     
==========================================
  Files         325      325              
  Lines       47671    47671              
==========================================
- Hits        18016    18005      -11     
- Misses      27067    27071       +4     
- Partials     2588     2595       +7
Impacted Files Coverage Δ
models/repo_indexer.go 44.49% <0%> (-6.36%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270fa6d...093daeb. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 7, 2019
@HarshitOnGitHub
Copy link
Contributor Author

(Forgot to mention that you will need to clear your browser's session storage before testing the PR otherwise you will see wrong results.)

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2019
@techknowlogick techknowlogick merged commit 1ac8f6f into go-gitea:master Jan 15, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies issue list on right sidebar should not show itself.
6 participants