Allow Macaron to be set to log through to gitea.log #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5667 +/- ##
==========================================
- Coverage 38.74% 38.71% -0.03%
==========================================
Files 330 330
Lines 48650 48697 +47
==========================================
+ Hits 18850 18855 +5
- Misses 27071 27112 +41
- Partials 2729 2730 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lunny
requested changes
Jan 9, 2019
8 tasks
zeripath
force-pushed
the
issue-4921-obey-http-log-settings
branch
from
3928da6
to
21e41f7
Compare
|
Hmm. We should probably have this setting on by default. It would considerably reduce the amount of text that's spewed out during tests. We should do this as a separate PR as the integration tests will require some logging before we do that. |
zeripath
force-pushed
the
issue-4921-obey-http-log-settings
branch
from
21e41f7
to
408015c
Compare
techknowlogick
approved these changes
Jan 15, 2019
bkcsoft
added
lgtm/need 1
zeripath
force-pushed
the
issue-4921-obey-http-log-settings
branch
from
cda22d1
to
57585bd
Compare
|
OK pushing the macaron logs to the files in the integration tests works but should be discussed in a different PR. |
lunny
requested changes
Jan 16, 2019
Fix 4291 Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
issue-4921-obey-http-log-settings
branch
from
57585bd
to
cb3ddf1
Compare
adelowo
approved these changes
Jan 25, 2019
GiteaBot
added
lgtm/done
|
@lunny Are you happy with the logs remaining at INFO for both Macaron and the router log? |
lunny
added
the
pr/breaking
lunny
approved these changes
Feb 6, 2019
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a mechanism to allow Macaron to be set to log through to the gitea.log rather than simply to the console.
Fix #4291
Signed-off-by: Andrew Thornton art27@cantab.net