Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for user specific themes #5668

Merged
merged 12 commits into from
Jan 9, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 8, 2019

Fixes #5281

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 8, 2019
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #5668 into master will decrease coverage by 0.01%.
The diff coverage is 14.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5668      +/-   ##
==========================================
- Coverage   37.79%   37.77%   -0.02%     
==========================================
  Files         322      323       +1     
  Lines       47544    47592      +48     
==========================================
+ Hits        17968    17977       +9     
- Misses      26987    27026      +39     
  Partials     2589     2589
Impacted Files Coverage Δ
models/migrations/migrations.go 2.61% <ø> (ø) ⬆️
modules/setting/setting.go 48.8% <ø> (ø) ⬆️
modules/auth/user_form.go 41.81% <0%> (-9.3%) ⬇️
models/migrations/v77.go 0% <0%> (ø)
routers/user/setting/account.go 26.66% <0%> (-4.59%) ⬇️
routers/routes/routes.go 85.05% <100%> (+0.04%) ⬆️
models/user.go 48.14% <62.5%> (+0.11%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea51868...b2471cb. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2019
@adelowo adelowo changed the title WIP: Allow for user specific themes Allow for user specific themes Jan 9, 2019
@adelowo
Copy link
Member Author

adelowo commented Jan 9, 2019

Removed WIP as it has been completed now

models/user.go Outdated Show resolved Hide resolved
modules/auth/user_form.go Outdated Show resolved Hide resolved
models/migrations/v77.go Outdated Show resolved Hide resolved
@lunny lunny added this to the 1.8.0 milestone Jan 9, 2019
@lunny
Copy link
Member

lunny commented Jan 9, 2019

[...itea/routers/init.go:61 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: mssql: ALTER TABLE only allows columns to be added that can contain nulls, or have a DEFAULT definition specified, or the column being added is an identity or timestamp column, or alternatively if none of the previous conditions are satisfied the table must be empty to allow addition of this column. Column 'theme' cannot be added to non-empty table 'user' because it does not satisfy these conditions.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2019
@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label Jan 9, 2019
@bkcsoft bkcsoft removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2019
@bkcsoft bkcsoft added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jan 9, 2019
@techknowlogick techknowlogick merged commit 8d2c24f into go-gitea:master Jan 9, 2019
@adelowo adelowo deleted the allow_user_defined_themes branch January 9, 2019 17:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User specific theme / ui settings
7 participants