Keep file permissions during database migration #5707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5290 added auto-migration to the docker entrypoint. It introduced a small security issue, by changing the file permissions of the
app.ini
to644
(read permissions for all users). The theapp.ini
contains multiple credentials (smtp, database).Either the user should be reponsible for appropriate file permissions, or the file permissions should be changed so that only the user can read this file (
600
).This PR removes the file permission change, so the user is responsible for that. I can change it to setting secure permissions if requested.