Skip to content

Fix migration bug #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

Fix migration bug #5762

merged 1 commit into from
Jan 18, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 18, 2019

If you start your gitea failed, please follow the steps,

  1. stop gitea if it's still running
  2. change table version's value from 79 to 78
  3. try start gitea

@lunny lunny added the type/bug label Jan 18, 2019
@lunny
Copy link
Member Author

lunny commented Jan 18, 2019

should fix #5759

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2019
@lunny lunny mentioned this pull request Jan 18, 2019
Closed
7 tasks
@codecov-io
Copy link

Codecov Report

Merging #5762 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5762      +/-   ##
==========================================
- Coverage   37.74%   37.72%   -0.02%     
==========================================
  Files         327      327              
  Lines       47803    47818      +15     
==========================================
  Hits        18041    18041              
- Misses      27168    27183      +15     
  Partials     2594     2594
Impacted Files Coverage Δ
models/migrations/v78.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ca106...4f924e8. Read the comment docs.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 18, 2019
zeripath
zeripath approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry about this peeps. As penance I'll make some migration integration tests.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 18, 2019
@techknowlogick techknowlogick merged commit 41f19e1 into go-gitea:master Jan 18, 2019
@securitaas
Copy link

It now works for me on mariadb. Thank you.

@zeripath zeripath mentioned this pull request Jan 18, 2019
Closed
@zeripath
Copy link
Contributor

I think we may need to do the above recommended changes on try.gitea.io

@lunny lunny deleted the lunny/fix_migration_bug branch January 19, 2019 16:08
@zeripath
Copy link
Contributor

zeripath commented Jan 19, 2019 •
edited
Loading

Hmm... I've just had a similar issue on sqlite moving from v1.7.0-rc3 to master. The migration is still wrong.

@lunny
Copy link
Member Author

lunny commented Jan 20, 2019

What's the log?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @securitaas @zeripath @techknowlogick @bkcsoft