Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix topics saving internal error and disable for archived repos #5821

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Fix topics saving internal error and disable for archived repos #5821

merged 2 commits into from
Jan 24, 2019

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 24, 2019

Currently when saving topics server returns error 500. Also topics should not be changed for archived repositories.

@lafriks lafriks added this to the 1.8.0 milestone Jan 24, 2019
@codecov-io
Copy link

codecov-io commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #5821 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5821   +/-   ##
=======================================
  Coverage   37.88%   37.88%           
=======================================
  Files         328      328           
  Lines       48260    48260           
=======================================
  Hits        18282    18282           
  Misses      27347    27347           
  Partials     2631     2631
Impacted Files Coverage Δ
routers/routes/routes.go 85.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec31ee1...a5a36a4. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2019
@lafriks lafriks merged commit cd83c2c into go-gitea:master Jan 24, 2019
@lafriks lafriks deleted the fix/archived_repo_topics branch January 24, 2019 10:22
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@lafriks @bmackinney
Fix topics saving internal error and disable for archived repos (go-g…
8332071 
…itea#5821)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @lunny @zeripath @bkcsoft