Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docs for the tree api #5834

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Added docs for the tree api #5834

merged 3 commits into from
Jan 24, 2019

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Jan 24, 2019 •
edited
Loading

This PR adds docs for the new endpoint introduced with #5403

Should I send a backport to 1.7?

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 24, 2019
@lafriks lafriks added type/docs This PR mainly updates/creates documentation backport/v1.7 labels Jan 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 24, 2019
@lafriks
Copy link
Member

lafriks commented Jan 24, 2019

Yes, I think it should be backported to 1.7.1

@kolaente kolaente mentioned this pull request Jan 24, 2019
Merged
@kolaente
Copy link
Member Author

kolaente commented Jan 24, 2019 •
edited
Loading

CI failed, I guess I'll have to update the sdk first. Wait, just saw I only need to add it to the swagger responses

@sapk sapk mentioned this pull request Jan 24, 2019
Merged
@sapk
Copy link
Member

sapk commented Jan 24, 2019

The mssql test failure seems un-related.

@techknowlogick
Copy link
Member

I've just re-triggered the build and will merge when it is successful.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@62da3be). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5834   +/-   ##
=========================================
  Coverage          ?   37.88%           
=========================================
  Files             ?      328           
  Lines             ?    48297           
  Branches          ?        0           
=========================================
  Hits              ?    18299           
  Misses            ?    27371           
  Partials          ?     2627
Impacted Files Coverage Δ
routers/api/v1/repo/tree.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62da3be...9cdee10. Read the comment docs.

@techknowlogick techknowlogick merged commit 9a137fa into go-gitea:master Jan 24, 2019
@kolaente kolaente deleted the add-tree-api-docs branch January 24, 2019 18:14
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@kolaente @bmackinney
Added docs for the tree api (go-gitea#5834)
bbda9a1 
* Added docs for the tree api

* Added missing response definition

* Fixed swagger docs
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kolaente @lafriks @sapk @techknowlogick @codecov-io @GiteaBot